[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/forwarding-sections-liblto.c:2
+// RUN: touch %t.o
+// RUN: %clang %t.o -### -flto 2>&1 | FileCheck %s
+// RUN: %clang %t.o -### -flto 2>&1 -ffunction-sections -fdata-sections | \
----------------
Using a default triple this way does not work on platforms with a default toolchain which doesn't use LTO.

Instead of adding a new file, you may rename gold-lto-sections.c and add more RUN lines there.

Change `-target x86_64-unknown-linux` to `--target=...` if you make such a change.


================
Comment at: llvm/test/LTO/PowerPC/data-sections-aix.ll:18
+
+; CHECK:      SYMBOL TABLE:
+; CHECK:      .data
----------------
Err I want that you test something like `0000000000000000 g     F .text  {{.*}} f`

Is the output not implemented in AIX?


================
Comment at: llvm/test/LTO/PowerPC/data-sections-linux.ll:18
+
+; CHECK:      SYMBOL TABLE:
+; CHECK:      .bss.var
----------------
Just test one line, something like `0000000000000000 g     O .data  {{.*}} var`

Is the output not implemented in AIX?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129401/new/

https://reviews.llvm.org/D129401