[PATCH] D130134: [lld-macho] Fold cfstrings with --deduplicate-literals

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/MachO/cfstring-dedup.s:40-51
+# LITERALS-ONLY:       Rebase table:
+# LITERALS-ONLY-NEXT:  segment  section          address  type
+# LITERALS-ONLY-NEXT:  __DATA_CONST __cfstring   {{.*}}   pointer
+# LITERALS-ONLY-NEXT:  __DATA_CONST __cfstring   {{.*}}   pointer
+# LITERALS-ONLY-NEXT:  __DATA_CONST __cfstring   {{.*}}   pointer
+# LITERALS-ONLY-EMPTY:
+# LITERALS-ONLY-NEXT:  Bind table:
----------------
keith wrote:
> int3 wrote:
> > isn't this identical to the `CHECK` lines above? don't think we need to define a separate CHECK prefix
> So this part is, but the first CHECK block isn't valid for this codepath, since it expects __TEXT,__text folding as well. I've combined these to avoid the duplication and pointed the original test to both prefixes, wdyt?
oh right. Yeah, this is a good solution, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130134/new/

https://reviews.llvm.org/D130134