[PATCH] D129084: [AMDGPU] gfx11 Fix VOP3 dot instructions

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 10:18:10 PDT 2022


rampitec added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:2072
   Intrinsic<
-    [llvm_i16_ty],   // %r
+    [llvm_half_ty],  // %r
     [
----------------
Petar.Avramovic wrote:
> Joe_Nash wrote:
> > @rampitec should look at these intrinsic changes. I am not familiar enough with other BF16 support to know if this is reasonable. 
> This only gets desired behavior in testing. The problem is that there is no bf16 in clang, i16 is used instead. Our td files rely on types. I am looking if can bypass type checks. It would be much cleaner if we had the bf16 type.
We cannot have bf16 type. This is not a question of compiler support, this is the support which does not exist in HW. If you can only do dots on the type you cannot generally support it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129084/new/

https://reviews.llvm.org/D129084



More information about the llvm-commits mailing list