[PATCH] D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW

Wed Jul 20 09:29:12 PDT 2022

mati865 added a comment.

I'm a little bit concerned this could break some projects in the wild but for projects that use it properly this sounds like huge win (as your LLVM results show).

================
Comment at: llvm/lib/IR/Mangler.cpp:246
+  if (GV->hasHiddenVisibility() && !GV->isDeclaration() &&
+      (TT.isWindowsGNUEnvironment() || TT.isWindowsCygwinEnvironment())) {
+
----------------
This could be simplified to `TT.isOSCygMing()`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130121/new/

https://reviews.llvm.org/D130121