[PATCH] D118076: Sinking or hoisting instructions between loops before fusion

[Aaron K via Phabricator via llvm-commits]

aaronkintel marked an inline comment as done.
aaronkintel added a comment.

Can someone please provide feedback for this review?



================
Comment at: llvm/test/Transforms/LoopFusion/no_sink_hoist_store.ll:25
+pre2:
+  %ptr = alloca i32
+  store i32 3, i32* %ptr
----------------
jcranmer-intel wrote:
> The alloca should be in the entry block for this test, should it not?
Do you mean it should be:
pre1:
  %ptr = alloca i32
....
pre2: 
  store i32 3, i32* %ptr

What is the reason for this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118076/new/

https://reviews.llvm.org/D118076