[PATCH] D129161: [MachinePipeliner] Consider only direct path successors when calculating circuit latency

Hendrik Greving via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 07:56:22 PDT 2022


hgreving accepted this revision.
hgreving added a comment.

LGTM



================
Comment at: llvm/include/llvm/CodeGen/MachinePipeliner.h:359
           continue;
         unsigned CurLatency = Succ.getLatency();
+        if (CurLatency > SuccLatency)
----------------
You could add an assertion that at least one of the successors should get here and we should never skip all successors, which would imply that sth with the nodes order is unexpected.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129161/new/

https://reviews.llvm.org/D129161



More information about the llvm-commits mailing list