[PATCH] D129936: [JITLink][COFF][x86_64] Reimplement ADDR32NB/REL32.

Wed Jul 20 06:01:37 PDT 2022

sunho added a comment.

I'm planning to submit the patch that deals with dllimport stubs that cleanly solve the out of reach issue, since I think we agreed on requiring clients to manually set dllimport attribute for external (external to jitdylib) functions.

================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:325
+    if (SymbolSet.empty())
+      continue;
     jitlink::Block *B = getGraphBlock(SecIndex);
----------------
sgraenitz wrote:
> How does your patch affect symbol sets so that they might be empty now?
It's actually the side effect of the last patch (not dead stripping asso

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129936/new/

https://reviews.llvm.org/D129936