[PATCH] D129107: [BOLT][HUGIFY] adds huge pages support of PIE/no-PIE binaries

[Alexey Moksyakov via Phabricator via llvm-commits]

yavtuk added a comment.

Hi @rafauler, is it possible to get user-func-reorder.c.tmp & user-func-reorder.c.tmp.exe for analyze?



================
Comment at: bolt/lib/Passes/Hugify.cpp:2-6
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
----------------
rafauler wrote:
> Outdated license
updated


================
Comment at: bolt/lib/RuntimeLibs/HugifyRuntimeLibrary.cpp:64-87
   const BinaryFunction *StartFunction =
       BC.getBinaryFunctionAtAddress(*(BC.StartFunctionAddress));
   assert(!StartFunction->isFragment() && "expected main function fragment");
   if (!StartFunction) {
     errs() << "BOLT-ERROR: failed to locate function at binary start address\n";
     exit(1);
   }
----------------
rafauler wrote:
> I think we can delete all of this, right? emitBinary() for HugyfiRuntimeLibrary doesn't need to do anything if you are already creating a new function in a new pass that will be called from the runtime.
> 
> And then go to HugifyRuntimeLibrary.h and delete
>       SecNames.push_back(".bolt.hugify.entries");
yes, you are right, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129107/new/

https://reviews.llvm.org/D129107