[PATCH] D130154: Windows packaging script. Script does not exit on configure/build/test failure.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: hans, thieta, russell.gallop.
CarlosAlbertoEnciso added a project: All.
CarlosAlbertoEnciso requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Due to a missing new line, the error code returned by the function is taking as another argument.

  call :function if errorlevel 1 exit /b 1

The code should be

  call :function
  if errorlevel 1 exit /b 1

Changed to use a simple '||' logic
`call :function || exit /b 1`


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130154

Files:
  llvm/utils/release/build_llvm_release.bat


Index: llvm/utils/release/build_llvm_release.bat
===================================================================
--- llvm/utils/release/build_llvm_release.bat
+++ llvm/utils/release/build_llvm_release.bat
@@ -106,8 +106,8 @@
 set OLDPATH=%PATH%
 
 REM Build the 32-bits and/or 64-bits binaries.
-call :do_build_32 if errorlevel 1 exit /b 1
-call :do_build_64 if errorlevel 1 exit /b 1
+call :do_build_32 || exit /b 1
+call :do_build_64 || exit /b 1
 exit /b 0
 
 ::==============================================================================


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130154.446077.patch
Type: text/x-patch
Size: 558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220720/a9bb76b8/attachment.bin>