[PATCH] D129899: Bazel BUILD file for BOLT

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D129899#3664760 <https://reviews.llvm.org/D129899#3664760>, @Amir wrote:

> In D129899#3664230 <https://reviews.llvm.org/D129899#3664230>, @GMNGeoffrey wrote:
>
>> In D129899#3664216 <https://reviews.llvm.org/D129899#3664216>, @Amir wrote:
>>
>>> Couple of questions:
>>>
>>> 1. Do I understand it correctly that BUILD.bazel file need to be kept in sync with CMakeLists.txt?
>>
>> Yes. In general, there's no way to automatically get the Bazel configuration from the CMake  one.
>
> I see. I know that bazel build is enabled in pre-merge checks but they are flaky at times, and may not trigger for direct pushes. I may look into adding a buildbot configuration with bazel build. If you have any examples of using bazel in buildbot, please let me know.
>
>>> 2. Is it possible to run check-bolt tests with bazel?
>>
>> Assuming that check-bolt runs lit tests, no. Support for lit tests is not available in the Bazel build. I prototyped something, but couldn't get it working with LLVM's peculiar layer on top of lit that is deeply intertwined with the CMake build. Some more discussion here: https://discourse.llvm.org/t/bazel-and-check-mlir-target-does-bazel-support-running-lit-tests/61898/6?u=gcmn
>
> Right, it invokes lit underneath. I would assume that you still use cmake build for LLVM testing?
>
> In D129899#3664230 <https://reviews.llvm.org/D129899#3664230>, @GMNGeoffrey wrote:
>
>> In D129899#3664216 <https://reviews.llvm.org/D129899#3664216>, @Amir wrote:
>>
>>> Couple of questions:
>>>
>>> 1. Do I understand it correctly that BUILD.bazel file need to be kept in sync with CMakeLists.txt?
>>
>> Yes. In general, there's no way to automatically get the Bazel configuration from the CMake  one.
>>
>>> 2. Is it possible to run check-bolt tests with bazel?
>>
>> Assuming that check-bolt runs lit tests, no. Support for lit tests is not available in the Bazel build. I prototyped something, but couldn't get it working with LLVM's peculiar layer on top of lit that is deeply intertwined with the CMake build. Some more discussion here: https://discourse.llvm.org/t/bazel-and-check-mlir-target-does-bazel-support-running-lit-tests/61898/6?u=gcmn

I want to mention the Bazel build is an unofficial build system and keeping it work isn't the community's responsibility.
Keeping it work is appreciated by folks who use the Bazel build, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129899/new/

https://reviews.llvm.org/D129899