[PATCH] D130141: [RISCV] Add part support of RISCV Zc Extension (Zca, Zcb, Zcmp)

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

Initial shallow comments:

- They're not ratified, they passed arch review 5 days ago and can be frozen. I don't know if the specs have even been updated to say frozen yet.

- I see a bunch of style violations (missing indentation, missing spaces around tokens, newlines around curly braces where there shouldn't be, bad camel case, missing newlines at ends of files).

- Please keep MC, codegen and optimisation pass patches separate, it makes it much easier to review.

- Are these mnemonics, especially for push/pop's operands, accepted by the GNU community or just dreamt up by the authors of the spec?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130141/new/

https://reviews.llvm.org/D130141