[PATCH] D130137: [lld-macho] Simplify archive loading logic

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:299
       // using the cached archive should be enough
-      if (entry->second.isCommandLineLoad ||
-          entry->second.isCommandLineLoad == isCommandLineLoad)
+      if (entry->second.isCommandLineLoad || isCommandLineLoad == false)
         return file;
----------------
thakis wrote:
> `!isCommandLineLoad` instead of `== false`
d'oh, of course


================
Comment at: lld/MachO/Driver.cpp:304
+    bool isLCLinkerForceLoad = loadType == LoadType::LCLinkerOption &&
+                               config->forceLoadSwift &&
+                               path::filename(path).startswith("libswift");
----------------
thakis wrote:
> Why `&& forceLoadSwift && path::filename(path).startswith("libswift")`? Does this in LC_LINKER_OPTIONS only apply to swift archives?
yup


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130137/new/

https://reviews.llvm.org/D130137