[PATCH] D130134: [lld-macho] Fold cfstrings with --deduplicate-literals

[Keith Smiley via Phabricator via llvm-commits]

keith added a comment.

Here's a repro case where this causes issues https://github.com/tapthaker/lld-reproducer, very similar to the standard cstring cases.



================
Comment at: lld/MachO/ICF.cpp:403
 
-void macho::foldIdenticalSections() {
+void macho::foldIdenticalSections(bool onlyCfStrings) {
   TimeTraceScope timeScope("Fold Identical Code Sections");
----------------
I'm not happy with hijacking this function for this specific use case, so it would probably make sense for me to try to extract something here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130134/new/

https://reviews.llvm.org/D130134