[PATCH] D130049: [WinSEH][ARM64] Split unwind info for functions larger than 1MB

[Z. Zheng via Phabricator via llvm-commits]

zzheng marked 2 inline comments as done.
zzheng added inline comments.


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:1095
+    // FIXME: We won't need this once we emit packed form (.pdata only) for this
+    //        kind of segments.
+    if (!HasEpilogs)
----------------
efriedma wrote:
> This FIXME doesn't really make sense; in general, we can't represent segments in pdata-only form.    Among other things, pdata-only form is limited to 8KB function length.
> 
> --------
> 
> I'm still not really convinced this "fake epilog" form is really useful, even if the Microsoft documentation suggests using it.
Let's keep it this way for now. We can remove it once we verified that MS unwinder is ok with zero epilog scope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130049/new/

https://reviews.llvm.org/D130049