[PATCH] D130126: fix bug for useless malloc elimination in CodeGenPrepare

[Ruobing Han via Phabricator via llvm-commits]

drcut updated this revision to Diff 445956.
drcut added a comment.

Reformat the test file with update_test_checks.py


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130126/new/

https://reviews.llvm.org/D130126

Files:
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/Transforms/CodeGenPrepare/dead-allocation.ll


Index: llvm/test/Transforms/CodeGenPrepare/dead-allocation.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/CodeGenPrepare/dead-allocation.ll
@@ -0,0 +1,23 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; Eliminate the dead allocation instruction
+; RUN: opt -codegenprepare < %s -S | FileCheck %s
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "armv7--linux-gnueabihf"
+
+ at .str = private unnamed_addr constant [2 x i8] c"a\00", align 1
+
+define void @func() {
+; CHECK-LABEL: @func(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    ret void
+;
+entry:
+  %0 = tail call noalias noundef nonnull dereferenceable(32) ptr @_Znwm(i64 noundef 32)
+  %1 = icmp ugt ptr %0, @.str
+  tail call void @llvm.assume(i1 %1)
+  ret void
+}
+
+declare noundef nonnull ptr @_Znwm(i64 noundef) local_unnamed_addr
+declare void @llvm.assume(i1 noundef)
Index: llvm/lib/Transforms/Utils/Local.cpp
===================================================================
--- llvm/lib/Transforms/Utils/Local.cpp
+++ llvm/lib/Transforms/Utils/Local.cpp
@@ -439,6 +439,9 @@
     return true;
   }
 
+  if (isAllocationFn(I, TLI) && isAllocRemovable(cast<CallBase>(I), TLI))
+    return true;
+
   if (!I->willReturn())
     return false;
 
@@ -489,9 +492,6 @@
     }
   }
 
-  if (isAllocationFn(I, TLI) && isAllocRemovable(cast<CallBase>(I), TLI))
-    return true;
-
   if (CallInst *CI = isFreeCall(I, TLI))
     if (Constant *C = dyn_cast<Constant>(CI->getArgOperand(0)))
       return C->isNullValue() || isa<UndefValue>(C);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130126.445956.patch
Type: text/x-patch
Size: 1631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220719/e1510b93/attachment.bin>