[PATCH] D129519: [Symbolizer] Implement contextual symbolizer markup elements.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath updated this revision to Diff 445938.
mysterymath marked an inline comment as done.
mysterymath added a comment.

I did a bit more hammering on the semantics of contexutal line elision.
Previously, contextual elements would be output as text if they were preceded
by text, which wasn't intended. Fixing this means that a non-contextual line
will be entirely deferred. This means that tryContextualLine() doesn't really
make sense anymore; it always handles the whole line. I've thus made the
modified version of it into the new body of filter().

I also made the deferred nodes a const parameter of the try calls again; this
seems cleaner than moving it out into the body, since it's produced by filter()
and possibly consumed by the try() calls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129519/new/

https://reviews.llvm.org/D129519

Files:
  llvm/docs/CommandGuide/llvm-symbolizer.rst
  llvm/docs/SymbolizerMarkupFormat.rst
  llvm/include/llvm/DebugInfo/Symbolize/Markup.h
  llvm/include/llvm/DebugInfo/Symbolize/MarkupFilter.h
  llvm/lib/DebugInfo/Symbolize/Markup.cpp
  llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp
  llvm/test/DebugInfo/symbolize-filter-markup-context-line-elision.test
  llvm/test/DebugInfo/symbolize-filter-markup-mmap.test
  llvm/test/DebugInfo/symbolize-filter-markup-module.test
  llvm/test/DebugInfo/symbolize-filter-markup-parse-fields.test
  llvm/test/DebugInfo/symbolize-filter-markup-reset.test
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129519.445938.patch
Type: text/x-patch
Size: 28783 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220719/f1bb7d2f/attachment.bin>