[PATCH] D129932: [AArch64] Use SUBXrx64 for dynamic stack to refer to sp

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 11:56:32 PDT 2022


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1718
+def : Pat<(sub copyFromSP:$R2, (arith_uxtx GPR64:$R3, arith_extendlsl64:$imm)),
+          (SUBXrx64 GPR64sponly:$R2, GPR64:$R3, arith_extendlsl64:$imm)>;
 }
----------------
Please use `SUBXrx64 GPR64sp:$R2` for clarity (although it shouldn't have any effect).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129932/new/

https://reviews.llvm.org/D129932



More information about the llvm-commits mailing list