[PATCH] D130105: [NFC][AMDGPU] Refactor AMDGPUDisassembler

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:1915
 
+// NOLINTNEXTLINE(readability-identifier-naming)
+MCDisassembler::DecodeStatus AMDGPUDisassembler::decodeCOMPUTE_PGM_RSRC3(
----------------
arsenm wrote:
> What are these comments?
They suppress clang-tidy diagnostics, with the idea here being that it is worth using the `COMPUTE_PGM_RSRC3` identifier from the KD specification directly in the method name, even though it breaks the normal LLVM style rules


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130105/new/

https://reviews.llvm.org/D130105