[PATCH] D129175: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld

[Sunho Kim via Phabricator via llvm-commits]

sunho marked 2 inline comments as done.
sunho added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/Orc/LLJIT.cpp:752
+    Layer->setAutoClaimResponsibilityForObjectSymbols(true);
+
   // FIXME: Explicit conversion to std::unique_ptr<ObjectLayer> added to silence
----------------
sgraenitz wrote:
> What about further conditions like `isOSLinux()` or `isOSBinFormatELF()`? The issue seems quite specific and `AutoClaimResponsibility` should be used with care. Intuitively, it seems we should tightening it to the exact platform as much as we can. It would also reduce the risk of breaking legacy use-cases downstream (which is the majority of RuntimeDyld users I think).
> 
> Are there good reasons why we wouldn't?
thanks for review! Yes, there was no paticular reason for not restricting the target.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129175/new/

https://reviews.llvm.org/D129175