[PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

[David Spickett via Phabricator via llvm-commits]

DavidSpickett marked an inline comment as done.
DavidSpickett added a comment.

> I am wondering if we should also test memory reads with correct/wrong tags for corefiles as well? Do you see any value on doing it or have done it already in above test and i skipped it?

You mean "memory read <the tagged memory buffer> --show-tags"? The details are tested on live processes already but a simple smoke test wouldn't hurt, I'll do that.



================
Comment at: lldb/test/API/linux/aarch64/mte_core_file/main.c:1
+// Program to generate core files to test MTE tag features.
+//
----------------
omjavaid wrote:
> Do we have a hardware board that supports MTE or we are still using QEMU?
Still using QEMU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129489/new/

https://reviews.llvm.org/D129489