[PATCH] D115381: [AArch64][GlobalISel] Select scalar G_FMAXIMUM + G_FMINIMUM

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 06:43:43 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrGISel.td:244-245
 
+def : GINodeEquiv<G_FMAXIMUM, fmaximum>;
+def : GINodeEquiv<G_FMINIMUM, fminimum>;
+
----------------
arsenm wrote:
> This is obvious, LGTM
Actually this doesn't LGTM. This belongs in generic code


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115381/new/

https://reviews.llvm.org/D115381



More information about the llvm-commits mailing list