[PATCH] D129936: [JITLink][COFF][x86_64] Reimplement ADDR32NB/REL32.

[Sunho Kim via Phabricator via llvm-commits]

sunho marked an inline comment as done.
sunho added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFF_x86_64.cpp:403
+  auto TT = (*COFFObj)->makeTriple();
+  TT.setObjectFormat(Triple::ObjectFormatType::COFF);
+  return COFFLinkGraphBuilder_x86_64(**COFFObj, TT).buildGraph();
----------------
sunho wrote:
> sgraenitz wrote:
> > What else could it be?
> I'm very uncertain about this part too. The tricky part is that makeTirple doesn't set COFF object format type for some reason. I tried chaning maketriple to set coff forat but it breaks several tests outside Orc. We can't just check with !isObjectFormatTypeELF() too as ELF is the default object format -- even for coff object format they are unchagned. I have to look into why maketriple doesn't set COFF object format. 
Made it better by setting format inside coffgraphbuilder.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129936/new/

https://reviews.llvm.org/D129936