[PATCH] D129686: [RISCV] Reuse a materialised global address in preference to merging into a load/store

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 06:02:48 PDT 2022


asb updated this revision to Diff 445795.
asb edited the summary of this revision.
asb added a comment.

Rebase, and only alter the codegen path if the C extension is enabled, update patch summary.

Any thoughts on this kind of transformation? I'm thinking it may make more sense as an extension to RISCVMakeCompressible (as then we can additionally gate the transformation on whether the load/store operand registers are compressible in the first place). And perhaps we want some parts of RISCVMakeCompressible to run even for optimisation modes other than Os/Oz (see e.g. #56390 <https://github.com/llvm/llvm-project/issues/56390> for another case this might be worthwhile).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129686/new/

https://reviews.llvm.org/D129686

Files:
  llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
  llvm/lib/Target/RISCV/RISCVISelDAGToDAG.h
  llvm/test/CodeGen/RISCV/fold-addi-loadstore.ll
  llvm/test/CodeGen/RISCV/global-merge-minsize.ll
  llvm/test/CodeGen/RISCV/global-merge-offset.ll
  llvm/test/CodeGen/RISCV/global-merge.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129686.445795.patch
Type: text/x-patch
Size: 13550 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220719/14b3d4fc/attachment-0001.bin>


More information about the llvm-commits mailing list