[PATCH] D130080: [InstCombine] Change order of canonicalization of ADD and AND

Tue Jul 19 05:47:51 PDT 2022

foad added reviewers: piotr, spatel, lebedev.ri, nikic, RKSimon.
foad added a comment.

This patch subsumes D129844 <https://reviews.llvm.org/D129844>.

I'm not sure what sort of testing is required to show that it improves (or at least doesn't degrade) codegen.

================
Comment at: llvm/test/Transforms/InstCombine/or.ll:163
+; CHECK-NEXT:    [[T6:%.*]] = or i32 [[T5]], [[T3]]
+; CHECK-NEXT:    ret i32 [[T6]]
 ;
----------------
This regression is unfortunate but I don't know what to do about it. Perhaps we can just live with it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130080/new/

https://reviews.llvm.org/D130080