[PATCH] D129851: [AArch64][SVE] Consider more intrinsics in 'isZeroingInactiveLanes'.

Tue Jul 19 05:46:07 PDT 2022

paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

I guess it won't be long before we need to add `while` to this list?

================
Comment at: llvm/test/CodeGen/AArch64/sve-ptest-removal-fcmpeq.ll:12
+; CHECK-NEXT:    fcmeq p1.s, p0/z, z0.s, z1.s
+; CHECK-NEXT:    ptest p0, p1.b
 ; CHECK-NEXT:    cset w0, ne
----------------
sdesmalen wrote:
> The fcm* instructions don't set the NCZV flags so the ptest cannot be removed. Perhaps I should rename these tests.
That does sound best.  Perhaps a generic sve-ptest.ll to verify the cases where ptest is required but we want to ensure no additional instructions are emitted.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129851/new/

https://reviews.llvm.org/D129851