[PATCH] D125784: [llvm-dva] 09 - CodeView Reader

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov added inline comments.


================
Comment at: llvm/test/tools/llvm-dva/COFF/01-coff-compare-logical-elements.test:41
+; ONE-NEXT:  [004]                   {Variable} 'CONSTANT' -> 'const int'
+; ONE-NEXT: +[004]                   {TypeAlias} 'INTEGER' -> 'int'
+
----------------
CarlosAlbertoEnciso wrote:
> psamolysov wrote:
> > Just a question:  does `+` mean the element was added in the Target and omitted in the Reference?
> That is correct. Using the command line
> ```
> llvm-dva --attribute=level --print=types test-codeview-clang.o test-codeview-msvc.o
> ```
> The logical views are:
> ```
> Logical View:
> [000]           {File} 'test-codeview-clang.o'
> 
> [001]             {CompileUnit} 'test.cpp'
> [002]               {TypeAlias} 'INTPTR' -> '* const int'
> [002]               {Function} extern not_inlined 'foo' -> 'int'
> [003]                 {TypeAlias} 'INTEGER' -> 'int'
> 
> Logical View:
> [000]           {File} 'test-codeview-msvc.o'
> 
> [001]             {CompileUnit} 'test.cpp'
> [002]               {TypeAlias} 'INTPTR' -> '* const int'
> [002]               {Function} extern not_inlined 'foo' -> 'int'
> [003]                 {Block}
> [004]                   {TypeAlias} 'INTEGER' -> 'int'
> ```
> For the comparison, with
> `Reference`: 'test-codeview-clang.o'
> `Target`: 'test-codeview-msvc.o'
> 
> ```
> ; ONE-NEXT: -[003]                 {TypeAlias} 'INTEGER' -> 'int'
> ```
> It means, that element (type) was deleted from the target.
> ```
> ; ONE-NEXT: +[004]                   {TypeAlias} 'INTEGER' -> 'int'
> ```
> It means, that element (type) was added in the target.
> 
Thank you very much for the good answer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784