[PATCH] D125783: [llvm-dva] 08 - ELF Reader

Tue Jul 19 05:00:10 PDT 2022

psamolysov added inline comments.

================
Comment at: llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp:243
+// Logical elements properties.
+void elementProperties(SmallString<128> &InputsDir) {
+  // Reader options.
----------------
CarlosAlbertoEnciso wrote:
> psamolysov wrote:
> > I believe this should work as well as for the `SmallVector<N>/SmallVectorImpl` pair.
> I can't find a similar `SmallString<N>/SmallStringImpl` pair.
Sorry, this is my bad. I forgot that `SamllString<N>` is just a derived class from `SmallVector<char, N>`, so you can use `SmallVectorImpl<char>` or just keep the code as it is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125783/new/

https://reviews.llvm.org/D125783