[PATCH] D130009: [AMDGPU][MC][NFC] Refine SMEM load definitions.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 04:32:51 PDT 2022


dp accepted this revision.
dp added a comment.
This revision is now accepted and ready to land.

Nice refactoring!
LGTM with a nit.



================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:167-169
+  def _IMM  : SM_Load_Pseudo <opName, baseClass, dstClass, IMM_Offset>;
+  def _SGPR  : SM_Load_Pseudo <opName, baseClass, dstClass, SGPR_Offset>;
+  def _SGPR_IMM  : SM_Load_Pseudo <opName, baseClass, dstClass, SGPR_IMM_Offset>;
----------------
Extra spaces may be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130009/new/

https://reviews.llvm.org/D130009



More information about the llvm-commits mailing list