[PATCH] D129137: [NFC][LoopVectorize] Explicitly disable tail-folding on some SVE tests

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 02:56:47 PDT 2022


sdesmalen requested changes to this revision.
sdesmalen added a comment.
This revision now requires changes to proceed.

In D129137#3659941 <https://reviews.llvm.org/D129137#3659941>, @david-arm wrote:

> 2. sve-epilog-vect-* - these fail when TF is enabled because we no longer create epilogues. However, it doesn't really make much sense to add new tail-folding RUN lines for these because then we won't perform epilogue vectorisation.

I think that this is actually hiding a bug. If you don't specify tail-folding in the RUN line, whatever default the target may set shouldn't be able to override the explicit request to do 'epilogue vectorization'. Conversely, explicitly requesting a certain vectorization style should override any vectorization styles that were set by default. If *both* tail folding and epilogue vectorization are requested through flags or hints, then that's a bug in the test itself.

Can you see if you can remove the `-prefer-predicate-over-epilogue=scalar-epilogue` from the `sve-epilog-vect-*` tests?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129137/new/

https://reviews.llvm.org/D129137



More information about the llvm-commits mailing list