[PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 02:07:34 PDT 2022


tschuett added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.h:27
 
+struct DWARFStrOffsetsInfo {
+  lldb::offset_t cu_offset;
----------------
If you would use a class instead of the struct, you could hide the member variables.

The class variant is slightly more verbose than the struct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130062/new/

https://reviews.llvm.org/D130062



More information about the llvm-commits mailing list