[PATCH] D129559: Windows packaging script. Include lld-link, llvm-lib and llvm-windres from stage0

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

@hans Thanks for all your feedback.



================
Comment at: llvm/utils/release/build_llvm_release.bat:72
+if exist %build_dir% (
+  REM Exit if the build directory already exists.
+  echo Build directory already exists: %build_dir%
----------------
hans wrote:
> nit: I'd drop the comment here, the code is clear enough.
Done.


================
Comment at: llvm/utils/release/build_llvm_release.bat:147
+  -DPython3_ROOT_DIR=%PYTHONHOME% ^
+  -DPYTHON_EXECUTABLE=%PYTHONHOME%\python.exe ^
+  -DLIBXML2_INCLUDE_DIRS=%libxmldir%/include/libxml2 ^
----------------
hans wrote:
> I don't think we were setting PYTHON_EXECUTABLE before?
You are right. It is not needed.


================
Comment at: llvm/utils/release/build_llvm_release.bat:171
+cmake -GNinja %cmake_flags% ..\llvm-project\llvm || exit /b
 ninja || ninja || ninja || exit /b
 REM ninja check-llvm || ninja check-llvm || ninja check-llvm || exit /b
----------------
hans wrote:
> If this or some other build step fails, we would previously exit the script. Now I think we will just exit this "sub routine". Is that what we want?
Good point.
To preserve the previous behaviour, adding code to exit the script if the function fails.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129559/new/

https://reviews.llvm.org/D129559