[PATCH] D129723: [NFC][ADT] Remove unnecessary struct

ppenguin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 19:20:55 PDT 2022


prehistoric-penguin updated this revision to Diff 445674.
prehistoric-penguin added a comment.

[NFC][ADT] Remove unnecessary struct ilist_node_traits


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129723/new/

https://reviews.llvm.org/D129723

Files:
  llvm/include/llvm/ADT/ilist.h


Index: llvm/include/llvm/ADT/ilist.h
===================================================================
--- llvm/include/llvm/ADT/ilist.h
+++ llvm/include/llvm/ADT/ilist.h
@@ -75,19 +75,12 @@
   }
 };
 
-/// A fragment for template traits for intrusive list that provides default
-/// node related operations.
-///
-/// TODO: Remove this layer of indirection.  It's not necessary.
-template <typename NodeTy>
-struct ilist_node_traits : ilist_alloc_traits<NodeTy>,
-                           ilist_callback_traits<NodeTy> {};
-
 /// Template traits for intrusive list.
 ///
 /// Customize callbacks and allocation semantics.
 template <typename NodeTy>
-struct ilist_traits : public ilist_node_traits<NodeTy> {};
+struct ilist_traits : ilist_alloc_traits<NodeTy>,
+                      ilist_callback_traits<NodeTy> {};
 
 /// Const traits should never be instantiated.
 template <typename Ty> struct ilist_traits<const Ty> {};


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129723.445674.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220719/359e7b47/attachment.bin>


More information about the llvm-commits mailing list