[PATCH] D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 13:43:46 PDT 2022


congzhe updated this revision to Diff 445613.
congzhe added a comment.

Thanks Michael for your suggestion, I've updated the patch accordingly.

I'm just wondering if you meant `A[trunc]=42` in your example? Also I'm a bit confused if the loop actually iterates over `A` twice? It looks to me the variable `i` loops from `0x0100` to `0x01FF`, hence `trunc` loops from `A[0x00]` to `A[0xFF]` so seems like it just iterates once?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128877/new/

https://reviews.llvm.org/D128877

Files:
  llvm/include/llvm/Analysis/LoopCacheAnalysis.h
  llvm/lib/Analysis/LoopCacheAnalysis.cpp
  llvm/test/Analysis/LoopCacheAnalysis/PowerPC/compute-cost.ll
  llvm/test/Analysis/LoopCacheAnalysis/compute-cost.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128877.445613.patch
Type: text/x-patch
Size: 7745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220718/70d859ff/attachment.bin>


More information about the llvm-commits mailing list