[PATCH] D128148: [XCOFF] write the aux header when the visibility is specified in XCOFF32.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:314
   size_t auxiliaryHeaderSize() const {
-    assert(!needsAuxiliaryHeader() &&
-           "Auxiliary header support not implemented.");
-    return 0;
+    return HasVisibility && !is64Bit() ? XCOFF::AuxFileHeaderSizeShort : 0;
   }
----------------
Esme wrote:
> DiggerLin wrote:
> > add some comment here :
> > // TODO: not support 64-bit auxiliary header.
> As the definition in aouthdr.h, 64-bit object files will not have the auxiliary header. So this should not be a TODO?
thanks  for the clarify.  do you want to add some comment for it (64-bit object files will not have the auxiliary header)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128148/new/

https://reviews.llvm.org/D128148