[PATCH] D129974: [BOLT] Support split function in stripped binaries

Mon Jul 18 12:06:25 PDT 2022

Amir added inline comments.

================
Comment at: bolt/lib/Core/BinaryContext.cpp:500

+bool BinaryContext::validJumpTableEntry(uint64_t EntryAddress,
+                                        BinaryFunction *BF,
----------------
Let's move this addition into a separate diff. It would be dependent on BC->IsStripped diff.

================
Comment at: bolt/test/X86/jump-table-move-pic.s:1
+# REQUIRES: system-linux
+
----------------
Please add a comment what this test is about: e.g. "Test -jump-tables=move with stripped/non-stripped binary with split function accessing the jump table, reproduces the unresolved symbol issue due to losing symbols referenced from a jump table"

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129974/new/

https://reviews.llvm.org/D129974