[PATCH] D129786: [llvm] add zstd to `llvm::compression` namespace
Cole Kissane via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 18 11:19:42 PDT 2022
ckissane added inline comments.
================
Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:79
+ set(ZSTD_ROOT @ZSTD_ROOT@)
+ find_package(ZSTD)
+endif()
----------------
sebastian-ne wrote:
> Should this be lower case zstd? I saw some cmake errors here and they disappear when this is lower case.
good catch, It should also probably be another find_dependency call instead of find_package so I fixed that too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129786/new/
https://reviews.llvm.org/D129786
More information about the llvm-commits
mailing list