[PATCH] D129915: [InstCombine] Tighten up known library function signature tests (PR #56463)

[Martin Sebor via Phabricator via llvm-commits]

msebor added inline comments.


================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:1073
+            FTy.getParamType(0) == FTy.getReturnType() &&
+            FTy.getParamType(1) == FTy.getParamType(1) &&
+            FTy.getParamType(2)->isIntegerTy(32) &&
----------------
nikic wrote:
> One of those is probably supposed to be getParamType(0)?
Right.  (And I wasn't even trying to make the point about the repetitive text obscuring the important difference.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129915/new/

https://reviews.llvm.org/D129915