[PATCH] D129844: [InstCombine] Restrict "(X & 0xFF00) + xx00 --> (X + xx00) & 0xFF00"

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I don't think the patch as written makes sense (we should never have one-use limitations on the leafs of a pattern, because the leafs are not affected by the fold). Changing canonicalization direction seems fine though, I don't think we have a strong preference one way or another. We should check whether there are any sibling folds (e.g. with `or`) that would also have to change direction, so we consistently do logic before arithmetic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129844/new/

https://reviews.llvm.org/D129844