[PATCH] D129537: [X86][DAGISel] Combine select vXi64 with AVX512 target

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:44372
+  uint64_t Mask = ConstCond->getZExtValue();
+  Mask = (Mask << 1) | Mask;
+  SDValue MaskVal = DAG.getConstant(
----------------
RKSimon wrote:
> This doesn't look right - shouldn't it be something like:
> 
> APInt Mask = APIntOps::ScaleBitMask(ConstCond->getAPIntValue(), NumElts * 2) ?
Thanks, Simon. ScaleBitMask perfectly fit this coputation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129537/new/

https://reviews.llvm.org/D129537