[PATCH] D129866: [llvm-size] Fix hang on invalid short commandline option

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 07:02:14 PDT 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG55b556e60c06: [llvm-size] Fix hang waiting for input on invalid short commandline option (authored by gbreynoo).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129866/new/

https://reviews.llvm.org/D129866

Files:
  llvm/tools/llvm-size/llvm-size.cpp


Index: llvm/tools/llvm-size/llvm-size.cpp
===================================================================
--- llvm/tools/llvm-size/llvm-size.cpp
+++ llvm/tools/llvm-size/llvm-size.cpp
@@ -868,8 +868,11 @@
   StringSaver Saver(A);
   SizeOptTable Tbl;
   ToolName = argv[0];
-  opt::InputArgList Args = Tbl.parseArgs(argc, argv, OPT_UNKNOWN, Saver,
-                                         [&](StringRef Msg) { error(Msg); });
+  opt::InputArgList Args =
+      Tbl.parseArgs(argc, argv, OPT_UNKNOWN, Saver, [&](StringRef Msg) {
+        error(Msg);
+        exit(1);
+      });
   if (Args.hasArg(OPT_help)) {
     Tbl.printHelp(
         outs(),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129866.445482.patch
Type: text/x-patch
Size: 652 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220718/ab409d3c/attachment.bin>


More information about the llvm-commits mailing list