[PATCH] D129874: [SCEV][NFC][CT] Cheaper handling of guards in isBasicBlockEntryGuardedByCond

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

In D129874#3659515 <https://reviews.llvm.org/D129874#3659515>, @nikic wrote:

> LG if this is faster for you in practice.
>
> Though I do have to wonder: Why are we not tracking guard intrinsics in AssumptionCache? Iterating over users of the declaration has the disadvantage that you may be looking at guards in many other functions, and that it will run into issues when we try to parallelize the pass manager. It seems like tracking them in AC the same way as assumptions shouldn't be too hard.

We don't really see impact because SCEV in our pipeline takes negligible time far less than noise. :( But hypothetically, this should be better because guards are not so numerous usually.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129874/new/

https://reviews.llvm.org/D129874