[PATCH] D129878: [SCEV][NFC][CT] Do not waste time proving contextual facts for unreached loops and blocks

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 05:55:52 PDT 2022


nikic added a comment.

Not seeing a difference either way from this patch. I don't think that unreachable blocks are common enough to have any meaningful impact on compile-time.



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:11015
   // Interpret a null as meaning no loop, where there is obviously no guard
-  // (interprocedural conditions notwithstanding).
-  if (!L) return true;
+  // (interprocedural conditions notwithstanding). Do not bother about unreached
+  // loops.
----------------
unreached -> unreachable


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129878/new/

https://reviews.llvm.org/D129878



More information about the llvm-commits mailing list