[PATCH] D129874: [SCEV][NFC][CT] Cheaper handling of guards in isBasicBlockEntryGuardedByCond

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 05:51:56 PDT 2022


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG if this is faster for you in practice.

Though I do have to wonder: Why are we not tracking guard intrinsics in AssumptionCache? Iterating over users of the declaration has the disadvantage that you may be looking at guards in many other functions, and that it will run into issues when we try to parallelize the pass manager. It seems like tracking them in AC the same way as assumptions shouldn't be too hard.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129874/new/

https://reviews.llvm.org/D129874



More information about the llvm-commits mailing list