[PATCH] D129966: [ARM] Remove VBICimm if no cleared bits are demanded

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 03:01:51 PDT 2022


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:19970
+    uint64_t Mask = ARM_AM::decodeVMOVModImm(ModImm, EltBits);
+    if ((OriginalDemandedBits & Mask) == 0)
+      return TLO.CombineTo(Op, Op0);
----------------
Looks like VBIC uses the complement of the immediate. Does that need to be considered when checking `Mask`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129966/new/

https://reviews.llvm.org/D129966



More information about the llvm-commits mailing list