[PATCH] D129561: [RS4GC] Fix over-restrictive assert in atomic memcpy/move handling

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 02:21:23 PDT 2022


mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:1705
       auto GetBaseAndOffset = [&](Value *Derived) {
-        assert(PointerToBase.count(Derived));
         unsigned AddressSpace = Derived->getType()->getPointerAddressSpace();
----------------
apilipenko wrote:
> I suggest handling the undef case explicitly. Just return undef if the input is undef. 
Same goes for poison I guess.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129561/new/

https://reviews.llvm.org/D129561



More information about the llvm-commits mailing list