[PATCH] D129990: [NFC] Remove some boilerplate from SmallVector header and unit tests

Dawid Jurczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 02:15:02 PDT 2022


yurai007 created this revision.
yurai007 added reviewers: dexonsmith, nikic, wolfgangp, dblaikie.
Herald added a project: All.
yurai007 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In SmallVector unit test, referring test suite members every time using 'this' (due to how nondependent name lookups works) is quite cumbersome
and can be improved with aliases. Some test cases already use this approach, in this change we expand that approach to whole test file.
In SmallVector header we use couple of times exactly same enable_if, in this change we de-duplicate it and declare only once.

Depends on: https://reviews.llvm.org/D129781


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129990

Files:
  llvm/include/llvm/ADT/SmallVector.h
  llvm/unittests/ADT/SmallVectorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129990.445424.patch
Type: text/x-patch
Size: 33129 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220718/61004f97/attachment.bin>


More information about the llvm-commits mailing list