[PATCH] D129786: [llvm] add zstd to `llvm::compression` namespace

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added a comment.

In D129786#3655910 <https://reviews.llvm.org/D129786#3655910>, @ckissane wrote:

> In D129786#3654396 <https://reviews.llvm.org/D129786#3654396>, @sebastian-ne wrote:
>
>> It seems like FindZSTD.cmake went missing in the Diff 3 revision of this patch?
>
> @sebastian-n yes because facebook is surprisingly good at "modern cmake" practices with shipping libzstd and so ```find_dependency(zstd)``` is enough to have the lib ```zstd::libzstd_shared``` get defined!
> I have hopes that this will fix the issues mac os users reported with the old version of this patch.

Nice, makes sense. It definitely fixes the issue when llvm is included with `add_subdirectory`.



================
Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:79
+  set(ZSTD_ROOT @ZSTD_ROOT@)
+  find_package(ZSTD)
+endif()
----------------
Should this be lower case zstd? I saw some cmake errors here and they disappear when this is lower case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129786/new/

https://reviews.llvm.org/D129786