[PATCH] D108699: [LAA] Analyze pointers forked by a select

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks!



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:916
+  if (Scevs.size() == 2)
+    return std::move(Scevs);
+
----------------
nit: unnecessary move?


================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/forked-pointers.ll:158
+; CHECK-NEXT:      Against group ([[G2:.+]]):
+; CHECK-NEXT:        %arrayidx = getelementptr inbounds i32, ptr %Preds, i64 %indvars.iv
+; CHECK-NEXT:    Check 1:
----------------
nit: it would probably be good to also have a few tests that access different sizes, including odd ones like `i23` or something like that, to ensure the right size expressions are used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108699/new/

https://reviews.llvm.org/D108699