[PATCH] D129692: [ARM] Correct features on pacbti tests. NFC

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 00:56:41 PDT 2022


chill added a comment.

In D129692#3658852 <https://reviews.llvm.org/D129692#3658852>, @dmgreen wrote:

> Oh I had that backwards then. The issue is that the instructions that it uses are all marked as requiring Armv8.1-m, so cannot be used validly in a Armv7-m build.
>
> Should the instructions be available when assembling for thumbv7m? If so I can just change the predicates on the PACBTIHintSpaceInst instructions. If not they may need to use HINT's or use some pseudos.

Ideally, we would like mnemonics (for NOP-space instructions only) to be available in v-7m and up, even though they were introduced in v8.1-m.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129692/new/

https://reviews.llvm.org/D129692



More information about the llvm-commits mailing list