[PATCH] D127864: [llvm-ar] Add object mode option -X for AIX

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/option-X.test:246
+
+# RUN: not llvm-ar -X32 -ma xcoff64elf64.o archive-any.a xcoff32.o 2>&1 | \
+# RUN:   FileCheck %s --check-prefixes=ERR-INSERT-POINT
----------------
Typo in the file name? I assume it shouldn't be "xcoff64elf64.o"!


================
Comment at: llvm/test/tools/llvm-ar/option-X.test:256-257
+## the same name, but different bitness in archive.
+## There is two xcoff.o in the archive-rep.a(the first one in the archive
+## is 32-bit,the second one is 64-bit).
+# RUN: cp archive-rep.a archive-rep-mov32.a
----------------



================
Comment at: llvm/test/tools/llvm-ar/option-X.test:260
+# RUN: llvm-ar -Xany -q archive-rep-mov32.a elf32.o elf64.o
+## Move the elf32.o to after the first 32-bit xcoff.o.
+# RUN: llvm-ar -X32 -ma xcoff.o archive-rep-mov32.a elf32.o
----------------
There's only one 32-bit xcoff.o. The "first" implied there was more.


================
Comment at: llvm/test/tools/llvm-ar/option-X.test:272
+# RUN: llvm-ar -Xany -q archive-rep-mov64.a elf32.o elf64.o
+## Move the elf64.o to after the second 64-bit xcoff.o.
+# RUN: llvm-ar -X64 -ma xcoff.o archive-rep-mov64.a elf64.o
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127864/new/

https://reviews.llvm.org/D127864